-
Notifications
You must be signed in to change notification settings - Fork 6
Add shared action to manage issue headers #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@marcellamaki @AlexVelezLl when watching the recording, you need to wait for a while after I added and then removed the label, it takes some time for the action to complete. |
|
The behavior and messages look good to me, @MisRob. Approved on my end in terms of the outcome of the workflow :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good to me!
| - name: Setup Node.js | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: '16' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Just curious) Is there a reason to use node 16 in this particular repository? Do we have any restriction in our dependencies or scripts to use this node version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied this + the script structure from another action which runs well. I think it affects the way the script is called at the bottom of this file and also how the main function is exported in the script part.
Also it's the most common version we use in other community actions, however I think that may be rather random choice.
It'd be good to eventually use same versions and also programming language, I plan to open an issue for that at some point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright @MisRob, thanks!
This reverts commit e8b9083.
|
Thanks both, I did the steps mentioned in the PR description + changed 'help wanted' bar color to blue. Now I will merge so I can test the final workflow in |
Summary
In our repositories, we will have the following workflow for managing issue headers based on the presence of 'help wanted' label:
(1) All issue templates will have "This issue is not open for contribution..." by default
(2) After labeling an issue with the 'help wanted', the header will be automatically changed to "This issue is open for contribution".
(3) After removing the 'help wanted' label, the header will be automatically changed back to "This issue is not open for contribution..."
See the recording for the demo of the whole process.
This pull request implements shared action that will address (2) and (3), after we turn it on in all main repositories.
Reviewer guidance
@marcellamaki The behavior and messages already include all feedback I received some time ago, so I think all should be ready. Would you just please preview the recording and if all looks good, give me final thumbs up?
@AlexVelezLl Would you please review code? You don't need to test it manually. I tested when I recorded the demo. After you review, I will
test-actionsthat all still works